Skip to content

fix(material-experimental/mdc-table): don't import template from other package #21594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix(material-experimental/mdc-table): don't import template from other package #21594

merged 1 commit into from
Jan 14, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jan 14, 2021 •
edited
Loading

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jan 14, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2021
crisbeto
crisbeto approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba force-pushed the revert-mdc-table-change branch from af67649 to 53a63f1 Compare January 14, 2021 21:32
@mmalerba mmalerba changed the title Revert "refactor(material-experimental/mdc-table): share code between… fix(material-experimental/mdc-table): don't import template from other package Jan 14, 2021
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 14, 2021
@mmalerba mmalerba merged commit dc33472 into angular:master Jan 14, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @crisbeto