-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService #21736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e881266
to
c4c2517
Compare
src/google-maps/map-directions-renderer/map-directions-service.ts
Outdated
Show resolved
Hide resolved
Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map.
Update public api guard with new component and service. Make minor optimizations with MapDirectionsService.
Add comments explaining how secret API key is loaded by dev-server.
3685264
to
7071884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can tackle the API key issue in a follow-up.
…angular#21736) * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Update public api guard with new component and service. Make minor optimizations with MapDirectionsService. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add comments explaining how secret API key is loaded by dev-server.
…angular#21736) * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Update public api guard with new component and service. Make minor optimizations with MapDirectionsService. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add comments explaining how secret API key is loaded by dev-server.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.