Skip to content

feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService #21736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

mbehrlich
Copy link
Collaborator

Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.

@mbehrlich mbehrlich requested review from devversion and a team as code owners January 28, 2021 23:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 28, 2021
@mbehrlich mbehrlich added area: google-maps feature This issue represents a new feature or feature request rather than a bug or bug fix labels Jan 29, 2021
Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.
Update public api guard with new component and service. Make minor
optimizations with MapDirectionsService.
Add comments explaining how secret API key is loaded by dev-server.
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can tackle the API key issue in a follow-up.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Feb 2, 2021
@annieyw annieyw merged commit 9dbf49b into angular:master Feb 5, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…angular#21736)

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Update public api guard with new component and service. Make minor
optimizations with MapDirectionsService.

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Add comments explaining how secret API key is loaded by dev-server.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…angular#21736)

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Update public api guard with new component and service. Make minor
optimizations with MapDirectionsService.

* feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService

Add comments explaining how secret API key is loaded by dev-server.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: google-maps cla: yes PR author has agreed to Google's Contributor License Agreement feature This issue represents a new feature or feature request rather than a bug or bug fix target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants