fix(google-maps): ensure that a mapTypeId is always passed in #22098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mbehrlich
approved these changes
Mar 11, 2021
| @@ -35,7 +35,8 @@ interface GoogleMapsWindow extends Window { | |||
| /** default options set to the Googleplex */ | |||
| export const DEFAULT_OPTIONS: google.maps.MapOptions = { | |||
| center: {lat: 37.421995, lng: -122.084092}, | |||
| zoom: 17 | |||
| zoom: 17, | |||
| mapTypeId: 'roadmap' | |||
There was a problem hiding this comment.
Getting this error internally:
TS2322: Type 'string' is not assignable to type 'MapTypeId | undefined'.
Could we instead do 'roadmap' as MapTypeId to resolve that?
There was a problem hiding this comment.
Done, although it's weird that our CI didn't catch it.
There was a problem hiding this comment.
Yeesh now I'm getting this
TS2352: Conversion of type 'string' to type 'MapTypeId' may be a mistake because
neither type sufficiently overlaps with the other. If this was intentional, convert the
expression to 'unknown' first.
b528880
to
c22ba94
Compare
We pass in `mapTypeId` as undefined if the provided options don't have it. This seems to trigger a bug in Google Maps where it stops loading map tiles. These changes fix the issue by always providing a `mapTypeId`. Fixes angular#22082.
crisbeto
force-pushed
the
22082/google-maps-type
branch
from
c22ba94
to
848b85f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass in
mapTypeIdas undefined if the provided options don't have it. This seems to trigger a bug in Google Maps where it stops loading map tiles.These changes fix the issue by always providing a
mapTypeId.Fixes #22082.