Skip to content

Conversation

crisbeto
Copy link
Member

The new Sass API removes some variables that had been previously exported by accident. These changes expand the migration so that usages of those variables are replaced with the values. The replacement doesn't cover variable assignments, because migrating them is impossible.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: rc This PR is targeted for the next release-candidate labels Apr 18, 2021
@crisbeto crisbeto requested review from jelbourn and devversion April 18, 2021 09:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Apr 18, 2021
… in sass api migration

The new Sass API removes some variables that had been previously exported by accident. These changes expand the migration so that usages of those variables are replaced with the values. The replacement doesn't cover variable assignments, because migrating them is impossible.
@crisbeto crisbeto force-pushed the sass-migration-removed-vars branch from 3cf1f80 to 587b9f4 Compare April 18, 2021 10:16
@wagnermaciel wagnermaciel merged commit 04d2f77 into angular:master Apr 21, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
… in sass api migration (#22505)

The new Sass API removes some variables that had been previously exported by accident. These changes expand the migration so that usages of those variables are replaced with the values. The replacement doesn't cover variable assignments, because migrating them is impossible.

(cherry picked from commit 04d2f77)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants