Skip to content

fix(material/expansion): unable to assign custom tabindex on header #22523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix(material/expansion): unable to assign custom tabindex on header #22523

merged 1 commit into from
Apr 22, 2021

Conversation

crisbeto
Copy link
Member

Adds the ability to assign a custom tabindex to the expansion panel header.

Fixes #22521.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 21, 2021
@crisbeto crisbeto requested a review from devversion April 21, 2021 15:27
@crisbeto crisbeto requested a review from jelbourn as a code owner April 21, 2021 15:27
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 21, 2021
@crisbeto crisbeto force-pushed the 22521/expansion-tabindex branch from a679969 to 7ebd460 Compare April 21, 2021 15:45
devversion
devversion approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two comments for the specs.

@crisbeto
fix(material/expansion): unable to assign custom tabindex on header
64792d6 
Adds the ability to assign a custom `tabindex` to the expansion panel header.

Fixes angular#22521.
@crisbeto crisbeto force-pushed the 22521/expansion-tabindex branch from 7ebd460 to 64792d6 Compare April 21, 2021 17:22
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 22, 2021
@wagnermaciel wagnermaciel merged commit 6c1383a into angular:master Apr 22, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set custom tabindex on mat-expansion-panel-header
3 participants
@crisbeto @devversion @wagnermaciel