Skip to content

fix(material/datepicker): incorrect year count in aria label #22763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

fix(material/datepicker): incorrect year count in aria label #22763

merged 1 commit into from
May 25, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the aria-label of the navigation buttons in the year view said "20 years", even though we're showing 24 years.

Fixes #22758.

@crisbeto
fix(material/datepicker): incorrect year count in aria label
ed1e4a0 
Fixes that the `aria-label` of the navigation buttons in the year view said "20 years", even though we're showing 24 years.

Fixes angular#22758.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 23, 2021
@crisbeto crisbeto requested a review from mmalerba May 23, 2021 10:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2021
mmalerba
mmalerba approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 24, 2021
@wagnermaciel wagnermaciel merged commit f3c3096 into angular:master May 25, 2021
wagnermaciel pushed a commit that referenced this pull request May 25, 2021
@crisbeto @wagnermaciel
fix(material/datepicker): incorrect year count in aria label (#22763)
f564961 
Fixes that the `aria-label` of the navigation buttons in the year view said "20 years", even though we're showing 24 years.

Fixes #22758.

(cherry picked from commit f3c3096)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Aria-Label on Datepicker Header for Next and Previous Year Selector Buttons
4 participants
@crisbeto @devversion @mmalerba @wagnermaciel