Skip to content

fix(material/slider): make value non-nullable #22912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix(material/slider): make value non-nullable #22912

merged 1 commit into from
Jun 10, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2021

Makes the value of the slider a number, rather than number | null in order to make it easier to use.

Fixes #22444.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 7, 2021
@crisbeto crisbeto requested review from mmalerba and wagnermaciel June 7, 2021 14:15
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2021
wagnermaciel
wagnermaciel reviewed Jun 7, 2021
View reviewed changes
@crisbeto
fix(material/slider): make value non-nullable
7606520 
Makes the value of the slider a `number`, rather than `number | null` in order to make it easier to use.

Fixes angular#22444.
@crisbeto crisbeto force-pushed the 22444/slider-non-nullable branch from 908b746 to 7606520 Compare June 7, 2021 14:38
wagnermaciel
wagnermaciel approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 7, 2021
@wagnermaciel wagnermaciel merged commit 71afc46 into angular:master Jun 10, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 10, 2021
@crisbeto @wagnermaciel
fix(material/slider): make value non-nullable (#22912)
383f7b6 
Makes the value of the slider a `number`, rather than `number | null` in order to make it easier to use.

Fixes #22444.

(cherry picked from commit 71afc46)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make slider value non-nullable
2 participants
@crisbeto @wagnermaciel