Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/overlay): use interface for test environment globals #23041

Merged
merged 1 commit into from Jun 28, 2021
Merged

fix(cdk/overlay): use interface for test environment globals #23041

merged 1 commit into from Jun 28, 2021

Conversation

jelbourn
Copy link
Member

The previous approach of using declare const was causing collisions with the real test environment types inside Google.

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue area: cdk/overlay labels Jun 22, 2021
@jelbourn jelbourn requested a review from crisbeto June 22, 2021 19:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2021
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jun 22, 2021
crisbeto
crisbeto approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cdk/overlay/overlay-container.ts Show resolved Hide resolved
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 22, 2021
@jelbourn
fix(cdk/overlay): use interface for test environment globals
2cb53ec 
The previous approach of using `declare const` was causing collisions with the real test environment types inside Google.
@amysorto amysorto merged commit da91c18 into angular:master Jun 28, 2021
amysorto pushed a commit that referenced this pull request Jun 28, 2021
@jelbourn @amysorto
fix(cdk/overlay): use interface for test environment globals (#23041)
4624ca8 
The previous approach of using `declare const` was causing collisions with the real test environment types inside Google.

(cherry picked from commit da91c18)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evmar evmar evmar left review comments

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/overlay cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jelbourn @evmar @crisbeto @amysorto