fix(material-experimental/mdc-chips): add 'required' to chips input #23055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
@jelbourn this seems reasonable to me, just wanted to check with you if there's any a11y implications I'm not aware of |
mmalerba
approved these changes
Jun 28, 2021
cpatin10
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
a team
as code owners
Adds missing 'required' attribute to chips input. Currently, chips add 'aria-required' only, which is for backwards compatibility. The addision also fixes a bug for axe tests that check for the same value fort 'required' and 'aria-required' attributes.
jelbourn
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 1, 2021
…23055) Adds missing 'required' attribute to chips input. Currently, chips add 'aria-required' only, which is for backwards compatibility. The addision also fixes a bug for axe tests that check for the same value fort 'required' and 'aria-required' attributes. Co-authored-by: Catalina Patiño <catpatin@google.com> (cherry picked from commit ca02022)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing 'required' attribute to chips input. Currently, chips add
'aria-required' only, which is for backwards compatibility.
The addision also fixes a bug for axe tests that check for the same
value fort 'required' and 'aria-required' attributes.