Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-form-field): color inputs not working #23095

Merged
merged 1 commit into from
Jul 9, 2021
Merged

fix(material-experimental/mdc-form-field): color inputs not working #23095

merged 1 commit into from
Jul 9, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the color type inputs didn't work due to a style override we had on top of MDC.

For reference:
Angular_Material_—_Mozilla_Firefox_2021-06-30_20-43-51

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 30, 2021
@crisbeto crisbeto requested a review from devversion June 30, 2021 18:53
@crisbeto crisbeto requested a review from mmalerba as a code owner June 30, 2021 18:53
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2021
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jun 30, 2021
@crisbeto
fix(material-experimental/mdc-form-field): color inputs not working
b9f4a1a 
Fixes that the `color` type inputs didn't work due to a style override we had on top of MDC.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 2, 2021
@wagnermaciel wagnermaciel merged commit ad06d7d into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-form-field): color inputs not working (#…
07f8c18 
…23095)

Fixes that the `color` type inputs didn't work due to a style override we had on top of MDC.

(cherry picked from commit ad06d7d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @devversion @wagnermaciel