-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to assign class to dialog #4718
Comments
Already mentioned / discussed in #4012 |
@donroyco what's the status of that? I can create a PR for this if it's not already done. |
No further development on the issue, as far as I know. |
Ok. Will create it |
Extend dialog config options to allow custom dialog class. Custom class enables media queries. angular#4718 angular#4012
Extend dialog config options to allow custom dialog class. Custom class enables media queries. angular#4718 angular#4012
Changed custom class config option name. Remove unnecessary class removal on detach. angular#4718 angular#4012
Added missing unit test to check if overlay pane has custom panel class. angular#4718 angular#4012
Change wrong comment. Remove unnecessary beforeEach from test. angular#4718 angular#4012
* feat(dialog): custom class option Extend dialog config options to allow custom dialog class. Custom class enables media queries. #4718 #4012 * refactor(dialog): custom class option. Changed custom class config option name. Remove unnecessary class removal on detach. #4718 #4012 * test(dialog): custom class option. Added missing unit test to check if overlay pane has custom panel class. #4718 #4012 * refactor(dialog): custom class option. Change wrong comment. Remove unnecessary beforeEach from test. #4718 #4012
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Feature request:
When I want to set dialog width from code I see that style is set to cdk-overlay-pane element but if I want to do that from css I don't have a way as I cannot set any class to cdk-overlay-pane.
This is useful when you need responsive widths so that you can write media queries which is imo a lot cleaner way than listening to window resize and changing width from code with updateSize method.
The text was updated successfully, but these errors were encountered: