-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" #14467
Merged
mmalerba
merged 7 commits into
master
from
revert-14407-14345/list-key-manager-active-item
Dec 11, 2018
Merged
Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" #14467
mmalerba
merged 7 commits into
master
from
revert-14407-14345/list-key-manager-active-item
Dec 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Dec 11, 2018
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…14469) * Revert "Revert "fix(radio): host element unable to receive focus events" (#14468)" This reverts commit 4aa47c7. * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…from ListKeyManager" (#14467) * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e. * Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager (#14407)" This reverts commit 014dc79.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…14469) * Revert "Revert "fix(radio): host element unable to receive focus events" (#14468)" This reverts commit 4aa47c7. * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df.
devversion
deleted the
revert-14407-14345/list-key-manager-active-item
branch
December 20, 2018 18:48
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…from ListKeyManager" (angular#14467) * Revert "build: update sauce connect (angular#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (angular#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (angular#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (angular#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (angular#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (angular#13956)" This reverts commit 41eb27e. * Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager (angular#14407)" This reverts commit 014dc79.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ular#14468) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (angular#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (angular#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (angular#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (angular#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (angular#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (angular#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (angular#13956)" This reverts commit 41eb27e.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ngular#14469) * Revert "Revert "fix(radio): host element unable to receive focus events" (angular#14468)" This reverts commit 4aa47c7. * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (angular#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (angular#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (angular#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (angular#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (angular#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (angular#13959)" This reverts commit e0eb3df.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14407
Caused change after checked errors in g3