Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove test blocklist #18372

Merged
merged 1 commit into from
Feb 4, 2020
Merged

build: remove test blocklist #18372

merged 1 commit into from
Feb 4, 2020

Conversation

devversion
Copy link
Member

The blocklist will be no longer used in the framework repository, so
we can remove it from the components repo too.

Related to FW-1807.

@devversion
build: remove test blocklist
23636e7 
The blocklist will be no longer used in the framework repository, so
we can remove it from the components repo too.

Related to FW-1807.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 3, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2020
@devversion devversion marked this pull request as ready for review February 3, 2020 09:55
@devversion devversion requested a review from a team as a code owner February 3, 2020 09:55
jelbourn
jelbourn approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 4, 2020
@mmalerba mmalerba merged commit e6e2382 into angular:master Feb 4, 2020
mmalerba pushed a commit that referenced this pull request Feb 5, 2020
@devversion @mmalerba
build: remove test blocklist (#18372)
0f7a828 
The blocklist will be no longer used in the framework repository, so
we can remove it from the components repo too.

Related to FW-1807.
yifange pushed a commit to yifange/components that referenced this pull request Feb 6, 2020
@devversion @yifange
build: remove test blocklist (angular#18372)
7791839 
The blocklist will be no longer used in the framework repository, so
we can remove it from the components repo too.

Related to FW-1807.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @googlebot @josephperrott @mmalerba