fix(material/card): not clearing margin on last button in end alignment #20040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
|
@crisbeto Looks like this breaks ~20 targets inside Google, mostly screenshot tests. Looking at the diffs, some of them are a bit off. Probably not worth the effort to update everything for now |
|
The screenshot failures are expected, because it removes some margin that wasn't supposed to be there in the first place. |
|
Not sure if I can comment on a pull request, but it seems like |
crisbeto
changed the title
We have some styles that clear the margin from the first button, but we didn't apply the same to the last button if the card actions are aligned towards the end. Fixes angular#20024.
crisbeto
force-pushed
the
20024/card-end-margin
branch
from
461203a
to
5c60918
Compare
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some styles that clear the margin from the first button, but we didn't apply the same to the last button if the card actions are aligned towards the end.
Fixes #20024.