feat(material-experimental/theming): add first part of token-based theming API #27000

mmalerba · 2023-04-27T22:43:33Z

No description provided.

github-actions · 2023-05-17T05:43:43Z

Deployed dev-app for bb50345 to: https://ng-dev-previews-comp--pr-angular-components-27000-jgmrc4wo.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

andrewseguin · 2023-05-22T14:47:33Z

Good naming on the matx =D

Is the design doc up to date on your latest theming API ideas?

mmalerba · 2023-05-22T17:29:23Z

The doc should capture what's in this PR, but I do need to update it to reflect some of the other ideas I've been prototyping

…eming API

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/16.0.3/16.1.1) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/16.0.3/16.1.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v16.1.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1611-lace-enigma-2023-06-14) [Compare Source](angular/components@16.1.0...16.1.1)  ### [`v16.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1610-epoxy-proxy-2023-06-13) [Compare Source](angular/components@16.0.4...16.1.0) ##### material | Commit | Type | Description | | -- | -- | -- | | [3703cc912c](angular/components@3703cc9) | feat | **select:** add input to control the panel width ([#27188](angular/components#27188)) | | [9aee2ee77f](angular/components@9aee2ee) | feat | **tabs:** synchronize ink bar animation with tab ([#27056](angular/components#27056)) | | [0028c6833f](angular/components@0028c68) | feat | **tooltip:** add isDisabled method to harness ([#27038](angular/components#27038)) | | [0a58155814](angular/components@0a58155) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#27050](angular/components#27050)) | | [764a68f980](angular/components@764a68f) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#27050](angular/components#27050)) | | [cda36e9a7a](angular/components@cda36e9) | fix | **form-field:** make notch sizing more reliable ([#26028](angular/components#26028)) | | [57adfe4fbf](angular/components@57adfe4) | fix | **select:** incorrect position if initialized late ([#27198](angular/components#27198)) | | [bb6f61b874](angular/components@bb6f61b) | fix | **select:** provide horizontal fallback positions ([#27267](angular/components#27267)) | | [feaaab9dc9](angular/components@feaaab9) | fix | **slider:** fix cd for sliders w/ form controls ([#27250](angular/components#27250)) | | [1cb210bf32](angular/components@1cb210b) | fix | **stepper:** two-way binding for selectedIndex ([#27232](angular/components#27232)) | | [7400746646](angular/components@7400746) | fix | **tabs:** prevent default keyboard actions on disabled links ([#27274](angular/components#27274)) | | [44b57a5b26](angular/components@44b57a5) | fix | **tooltip:** change tooltip to use MDC's token API | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [aec23ac348](angular/components@aec23ac) | feat | **theming:** add first part of token-based theming API ([#27000](angular/components#27000)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [33a9543f61](angular/components@33a9543) | fix | fix VoiceOver confused by Select/Autocomplete's ARIA semantics ([#26861](angular/components#26861)) |  ### [`v16.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1604-zirconium-zebra-2023-06-08) [Compare Source](angular/components@16.0.3...16.0.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [f595c783c](angular/components@f595c78) | fix | **core:** Fix MacOS Hover feature compatibility with optgroup ([#27239](angular/components#27239)) | | [8fafa88ef](angular/components@8fafa88) | fix | **slider:** fix track getting out of sync ([#27218](angular/components#27218)) | | [c19bd4c77](angular/components@c19bd4c) | fix | **slider:** handle contextmenu events ([#27227](angular/components#27227)) | | [52a80fef1](angular/components@52a80fe) | fix | **tabs:** default stretchTabs value not picked up by nav bar ([#27212](angular/components#27212)) | | [b6a9895a0](angular/components@b6a9895) | fix | **tabs:** tab header is clickable if its disable ([#27091](angular/components#27091)) |  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1929 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-07-01T00:11:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Apr 27, 2023

mmalerba force-pushed the token-api branch 9 times, most recently from 6f3ff25 to 4ab27fc Compare May 16, 2023 22:11

angular deleted a comment from github-actions bot May 16, 2023

mmalerba added dev-app preview When applied, previews of the dev-app are deployed to Firebase and removed dev-app preview When applied, previews of the dev-app are deployed to Firebase labels May 16, 2023

mmalerba force-pushed the token-api branch 2 times, most recently from 3a43e15 to 96f7d46 Compare May 16, 2023 22:18

mmalerba changed the title ~~Prototype: token-based theming API~~ fix(material-experimental/theming): add first part of token-based theming API May 16, 2023

mmalerba force-pushed the token-api branch from 96f7d46 to 2ce0c77 Compare May 16, 2023 22:19

mmalerba changed the title ~~fix(material-experimental/theming): add first part of token-based theming API~~ feat(material-experimental/theming): add first part of token-based theming API May 16, 2023

mmalerba marked this pull request as ready for review May 16, 2023 22:20

mmalerba requested review from devversion and andrewseguin as code owners May 16, 2023 22:20

angular-robot bot added the detected: feature PR contains a feature commit label May 16, 2023

mmalerba assigned jelbourn and andrewseguin May 16, 2023

mmalerba force-pushed the token-api branch 5 times, most recently from 36da6ca to b1d8437 Compare May 17, 2023 05:38

mmalerba force-pushed the token-api branch from 00865db to a3a5e82 Compare May 17, 2023 20:54

mmalerba requested a review from crisbeto as a code owner May 17, 2023 20:54

mmalerba force-pushed the token-api branch from a3a5e82 to 53cb923 Compare May 17, 2023 21:07

mmalerba added the target: patch This PR is targeted for the next patch release label May 17, 2023

mmalerba force-pushed the token-api branch from 53cb923 to 9e2df58 Compare May 17, 2023 21:21

josephperrott approved these changes May 18, 2023

View reviewed changes

mmalerba force-pushed the token-api branch from 1ec0264 to 254f92f Compare May 19, 2023 23:34

andrewseguin approved these changes May 22, 2023

View reviewed changes

mmalerba added the action: merge The PR is ready for merge by the caretaker label May 22, 2023

mmalerba force-pushed the token-api branch 2 times, most recently from 9666c09 to 55c7a7c Compare May 31, 2023 03:31

mmalerba added 8 commits May 31, 2023 15:44

feat(material-experimental/theming): add first part of token-based th…

b6ef728

…eming API

Set up a query parameter to use the token-based Sass API in the dev-app

2c8bf9e

Generate all M2 tokens from a theme object

f8a81c7

Add mixins to emit the theme based on tokens

e35883e

Add the new mat.theme API

45044b5

fixup! Add the new mat.theme API

1e230c7

tweaks based on recent feedback and discussions

f907943

addressed more feedback

eaf4410

mmalerba force-pushed the token-api branch from 55c7a7c to 22d3524 Compare May 31, 2023 15:47

mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 31, 2023

fixup! addressed more feedback

bb50345

mmalerba force-pushed the token-api branch from 22d3524 to bb50345 Compare May 31, 2023 17:35

mmalerba merged commit aec23ac into angular:main May 31, 2023
19 of 22 checks passed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(material-experimental/theming): add first part of token-based theming API #27000

feat(material-experimental/theming): add first part of token-based theming API #27000

mmalerba commented Apr 27, 2023

github-actions bot commented May 17, 2023 •

edited

andrewseguin commented May 22, 2023

mmalerba commented May 22, 2023

angular-automatic-lock-bot bot commented Jul 1, 2023

feat(material-experimental/theming): add first part of token-based theming API #27000

feat(material-experimental/theming): add first part of token-based theming API #27000

Conversation

mmalerba commented Apr 27, 2023

github-actions bot commented May 17, 2023 • edited

andrewseguin commented May 22, 2023

mmalerba commented May 22, 2023

angular-automatic-lock-bot bot commented Jul 1, 2023

github-actions bot commented May 17, 2023 •

edited