fix(material/select): incorrect position if initialized late #27198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that in some cases the select was resolving its overlay origin too early which caused it to position itself incorrectly when it is opened. Fixes angular#27063.
crisbeto
added
P3
andrewseguin
approved these changes
May 31, 2023
crisbeto
added
action: merge
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 15, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/16.0.3/16.1.1) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/16.0.3/16.1.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v16.1.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1611-lace-enigma-2023-06-14) [Compare Source](angular/components@16.1.0...16.1.1) <!-- CHANGELOG SPLIT MARKER --> ### [`v16.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1610-epoxy-proxy-2023-06-13) [Compare Source](angular/components@16.0.4...16.1.0) ##### material | Commit | Type | Description | | -- | -- | -- | | [3703cc912c](angular/components@3703cc9) | feat | **select:** add input to control the panel width ([#​27188](angular/components#27188)) | | [9aee2ee77f](angular/components@9aee2ee) | feat | **tabs:** synchronize ink bar animation with tab ([#​27056](angular/components#27056)) | | [0028c6833f](angular/components@0028c68) | feat | **tooltip:** add isDisabled method to harness ([#​27038](angular/components#27038)) | | [0a58155814](angular/components@0a58155) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#​27050](angular/components#27050)) | | [764a68f980](angular/components@764a68f) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#​27050](angular/components#27050)) | | [cda36e9a7a](angular/components@cda36e9) | fix | **form-field:** make notch sizing more reliable ([#​26028](angular/components#26028)) | | [57adfe4fbf](angular/components@57adfe4) | fix | **select:** incorrect position if initialized late ([#​27198](angular/components#27198)) | | [bb6f61b874](angular/components@bb6f61b) | fix | **select:** provide horizontal fallback positions ([#​27267](angular/components#27267)) | | [feaaab9dc9](angular/components@feaaab9) | fix | **slider:** fix cd for sliders w/ form controls ([#​27250](angular/components#27250)) | | [1cb210bf32](angular/components@1cb210b) | fix | **stepper:** two-way binding for selectedIndex ([#​27232](angular/components#27232)) | | [7400746646](angular/components@7400746) | fix | **tabs:** prevent default keyboard actions on disabled links ([#​27274](angular/components#27274)) | | [44b57a5b26](angular/components@44b57a5) | fix | **tooltip:** change tooltip to use MDC's token API | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [aec23ac348](angular/components@aec23ac) | feat | **theming:** add first part of token-based theming API ([#​27000](angular/components#27000)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [33a9543f61](angular/components@33a9543) | fix | fix VoiceOver confused by Select/Autocomplete's ARIA semantics ([#​26861](angular/components#26861)) | <!-- CHANGELOG SPLIT MARKER --> ### [`v16.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1604-zirconium-zebra-2023-06-08) [Compare Source](angular/components@16.0.3...16.0.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [f595c783c](angular/components@f595c78) | fix | **core:** Fix MacOS Hover feature compatibility with optgroup ([#​27239](angular/components#27239)) | | [8fafa88ef](angular/components@8fafa88) | fix | **slider:** fix track getting out of sync ([#​27218](angular/components#27218)) | | [c19bd4c77](angular/components@c19bd4c) | fix | **slider:** handle contextmenu events ([#​27227](angular/components#27227)) | | [52a80fef1](angular/components@52a80fe) | fix | **tabs:** default stretchTabs value not picked up by nav bar ([#​27212](angular/components#27212)) | | [b6a9895a0](angular/components@b6a9895) | fix | **tabs:** tab header is clickable if its disable ([#​27091](angular/components#27091)) | <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjExOC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1929 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that in some cases the select was resolving its overlay origin too early which caused it to position itself incorrectly when it is opened.
Fixes #27063.