Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/stepper): two-way binding for selectedIndex #27232

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jun 4, 2023

adds two-way binding for selectedIndex, previously stepper had selectionChange which include selectedIndex & other properties in it

fixes #15627

@naaajii naaajii requested a review from mmalerba as a code owner June 4, 2023 19:16
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the CI is failing. Also we should have a test for the new output.

adds two-way binding for selectedIndex, previously stepper had selectionChange which include selectedIndex & other properties in it

fixes angular#15627
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 6, 2023
@crisbeto crisbeto merged commit 1cb210b into angular:main Jun 6, 2023
24 of 26 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 15, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/16.0.3/16.1.1) |
| [@angular/material](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/16.0.3/16.1.1) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v16.1.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1611-lace-enigma-2023-06-14)

[Compare Source](angular/components@16.1.0...16.1.1)

<!-- CHANGELOG SPLIT MARKER -->

### [`v16.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1610-epoxy-proxy-2023-06-13)

[Compare Source](angular/components@16.0.4...16.1.0)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [3703cc912c](angular/components@3703cc9) | feat | **select:** add input to control the panel width ([#&#8203;27188](angular/components#27188)) |
| [9aee2ee77f](angular/components@9aee2ee) | feat | **tabs:** synchronize ink bar animation with tab ([#&#8203;27056](angular/components#27056)) |
| [0028c6833f](angular/components@0028c68) | feat | **tooltip:** add isDisabled method to harness ([#&#8203;27038](angular/components#27038)) |
| [0a58155814](angular/components@0a58155) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#&#8203;27050](angular/components#27050)) |
| [764a68f980](angular/components@764a68f) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#&#8203;27050](angular/components#27050)) |
| [cda36e9a7a](angular/components@cda36e9) | fix | **form-field:** make notch sizing more reliable ([#&#8203;26028](angular/components#26028)) |
| [57adfe4fbf](angular/components@57adfe4) | fix | **select:** incorrect position if initialized late ([#&#8203;27198](angular/components#27198)) |
| [bb6f61b874](angular/components@bb6f61b) | fix | **select:** provide horizontal fallback positions ([#&#8203;27267](angular/components#27267)) |
| [feaaab9dc9](angular/components@feaaab9) | fix | **slider:** fix cd for sliders w/ form controls ([#&#8203;27250](angular/components#27250)) |
| [1cb210bf32](angular/components@1cb210b) | fix | **stepper:** two-way binding for selectedIndex ([#&#8203;27232](angular/components#27232)) |
| [7400746646](angular/components@7400746) | fix | **tabs:** prevent default keyboard actions on disabled links ([#&#8203;27274](angular/components#27274)) |
| [44b57a5b26](angular/components@44b57a5) | fix | **tooltip:** change tooltip to use MDC's token API |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [aec23ac348](angular/components@aec23ac) | feat | **theming:** add first part of token-based theming API ([#&#8203;27000](angular/components#27000)) |

##### multiple

| Commit | Type | Description |
| -- | -- | -- |
| [33a9543f61](angular/components@33a9543) | fix | fix VoiceOver confused by Select/Autocomplete's ARIA semantics ([#&#8203;26861](angular/components#26861)) |

<!-- CHANGELOG SPLIT MARKER -->

### [`v16.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1604-zirconium-zebra-2023-06-08)

[Compare Source](angular/components@16.0.3...16.0.4)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [f595c783c](angular/components@f595c78) | fix | **core:** Fix MacOS Hover feature compatibility with optgroup ([#&#8203;27239](angular/components#27239)) |
| [8fafa88ef](angular/components@8fafa88) | fix | **slider:** fix track getting out of sync ([#&#8203;27218](angular/components#27218)) |
| [c19bd4c77](angular/components@c19bd4c) | fix | **slider:** handle contextmenu events ([#&#8203;27227](angular/components#27227)) |
| [52a80fef1](angular/components@52a80fe) | fix | **tabs:** default stretchTabs value not picked up by nav bar ([#&#8203;27212](angular/components#27212)) |
| [b6a9895a0](angular/components@b6a9895) | fix | **tabs:** tab header is clickable if its disable ([#&#8203;27091](angular/components#27091)) |

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjExOC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1929
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing stepper header and setting selectedIndex programmatically does not work correct
2 participants