New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/core): Fix MacOS Hover feature compatibility with optgroup #27239
Conversation
Corrects ARIA semantics for the mat-optgroup component. Add role="presentation" to the label and remove aria-hidden="true" from the label. Fix compatibility issue with MAC Hover text a11y feature angular#27080. The label of the option group does not need to be aria-hidden, and the Mac Hover text feature seems to rely on it. Previous PR#27081 fixed this issue for legacy component. This PR fixes it for the non-legacy optgroup component. Fix angular#27080
Deployed dev-app for 85946f1 to: https://ng-dev-previews-comp--pr-angular-components-27239-vyi0pea9.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
…up (#27239) Corrects ARIA semantics for the mat-optgroup component. Add role="presentation" to the label and remove aria-hidden="true" from the label. Fix compatibility issue with MAC Hover text a11y feature #27080. The label of the option group does not need to be aria-hidden, and the Mac Hover text feature seems to rely on it. Previous PR#27081 fixed this issue for legacy component. This PR fixes it for the non-legacy optgroup component. Fix #27080 (cherry picked from commit 91fbe76)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/16.0.3/16.1.1) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`16.0.3` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/16.0.3/16.1.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v16.1.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1611-lace-enigma-2023-06-14) [Compare Source](angular/components@16.1.0...16.1.1) <!-- CHANGELOG SPLIT MARKER --> ### [`v16.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1610-epoxy-proxy-2023-06-13) [Compare Source](angular/components@16.0.4...16.1.0) ##### material | Commit | Type | Description | | -- | -- | -- | | [3703cc912c](angular/components@3703cc9) | feat | **select:** add input to control the panel width ([#​27188](angular/components#27188)) | | [9aee2ee77f](angular/components@9aee2ee) | feat | **tabs:** synchronize ink bar animation with tab ([#​27056](angular/components#27056)) | | [0028c6833f](angular/components@0028c68) | feat | **tooltip:** add isDisabled method to harness ([#​27038](angular/components#27038)) | | [0a58155814](angular/components@0a58155) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#​27050](angular/components#27050)) | | [764a68f980](angular/components@764a68f) | fix | **form-field:** ensure prefix and suffix are on top of other content ([#​27050](angular/components#27050)) | | [cda36e9a7a](angular/components@cda36e9) | fix | **form-field:** make notch sizing more reliable ([#​26028](angular/components#26028)) | | [57adfe4fbf](angular/components@57adfe4) | fix | **select:** incorrect position if initialized late ([#​27198](angular/components#27198)) | | [bb6f61b874](angular/components@bb6f61b) | fix | **select:** provide horizontal fallback positions ([#​27267](angular/components#27267)) | | [feaaab9dc9](angular/components@feaaab9) | fix | **slider:** fix cd for sliders w/ form controls ([#​27250](angular/components#27250)) | | [1cb210bf32](angular/components@1cb210b) | fix | **stepper:** two-way binding for selectedIndex ([#​27232](angular/components#27232)) | | [7400746646](angular/components@7400746) | fix | **tabs:** prevent default keyboard actions on disabled links ([#​27274](angular/components#27274)) | | [44b57a5b26](angular/components@44b57a5) | fix | **tooltip:** change tooltip to use MDC's token API | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [aec23ac348](angular/components@aec23ac) | feat | **theming:** add first part of token-based theming API ([#​27000](angular/components#27000)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [33a9543f61](angular/components@33a9543) | fix | fix VoiceOver confused by Select/Autocomplete's ARIA semantics ([#​26861](angular/components#26861)) | <!-- CHANGELOG SPLIT MARKER --> ### [`v16.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1604-zirconium-zebra-2023-06-08) [Compare Source](angular/components@16.0.3...16.0.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [f595c783c](angular/components@f595c78) | fix | **core:** Fix MacOS Hover feature compatibility with optgroup ([#​27239](angular/components#27239)) | | [8fafa88ef](angular/components@8fafa88) | fix | **slider:** fix track getting out of sync ([#​27218](angular/components#27218)) | | [c19bd4c77](angular/components@c19bd4c) | fix | **slider:** handle contextmenu events ([#​27227](angular/components#27227)) | | [52a80fef1](angular/components@52a80fe) | fix | **tabs:** default stretchTabs value not picked up by nav bar ([#​27212](angular/components#27212)) | | [b6a9895a0](angular/components@b6a9895) | fix | **tabs:** tab header is clickable if its disable ([#​27091](angular/components#27091)) | <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjExOC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1929 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Corrects ARIA semantics for the mat-optgroup component. Add role="presentation" to the label and remove aria-hidden="true" from the label.
Fix compatibility issue with MAC Hover text a11y feature #27080. The label of the option group does not need to be aria-hidden, and the Mac Hover text feature seems to rely on it.
Previous PR#27081 fixed this issue for legacy component. This PR fixes it for the non-legacy optgroup component.
Fix #27080