-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/paginator): items per page form field touch target size insufficient #29109
fix(material/paginator): items per page form field touch target size insufficient #29109
Conversation
items per page form field touch target does not have sufficient touch target size (48 x 48) fixes b/202731532
…arget added transparent touch target element on top of paginator select to get touch target to 48 pixel height Fixes b/225394124
add new line fixes b/225394124
Deployed dev-app for 07f55a8 to: https://ng-dev-previews-comp--pr-angular-components-29109-dev-dq7gxpzg.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
The touch target escapes the bounds of the paginator when the density is Code for reference: https://github.com/search?q=repo%3Aangular%2Fcomponents%20touch-target-display&type=code |
added density tokens for paginator touch target Fixes b/225394124
fix lint error fixes #225394124
Added density tokens to paginator |
…insufficient (#29109) * fix(material/paginator): items per page form field touch target issue items per page form field touch target does not have sufficient touch target size (48 x 48) fixes b/202731532 * fix(material/paginator): added transparent element for larger touch target added transparent touch target element on top of paginator select to get touch target to 48 pixel height Fixes b/225394124 * fix(material/paginator): add new line add new line fixes b/225394124 * fix(material/paginator): added density tokens added density tokens for paginator touch target Fixes b/225394124 * fix(material/paginator): fix lint error fix lint error fixes #225394124 (cherry picked from commit 99b3312)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Items per page form field touch target does not have sufficient touch target size of 48 x 48 pixels.
Changed from 84 x 41 to 84 x 48 pixels.
Before:
After:
fixes b/225394124