Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/tree): aria-expanded attribute should not appear in the leaf node #29273

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(material/tree): aria-expanded attribute should not appear in the leaf node #29273

merged 2 commits into from
Jul 3, 2024

Conversation

DBowen33
Copy link
Contributor

Fixed an issue to where leaf nodes were wrongly being assigned the aria-expanded attribute, which could confuse screen reader users.

https://screencast.googleplex.com/cast/NjMzNDkwNjM4MzcyODY0MHxkMTY5ZTdkNC05Mw

Fixes #21922
Fixes #21143

@DBowen33 DBowen33 marked this pull request as ready for review June 17, 2024 20:55
@DBowen33 DBowen33 requested a review from a team as a code owner June 17, 2024 20:55
@DBowen33 DBowen33 requested review from amysorto and andrewseguin and removed request for a team June 17, 2024 20:55
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2024
@andrewseguin andrewseguin removed the request for review from amysorto July 3, 2024 16:15
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 3, 2024
@DBowen33 DBowen33 requested a review from a team as a code owner July 3, 2024 16:32
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Jul 3, 2024
@angular-robot angular-robot bot removed detected: feature PR contains a feature commit area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Jul 3, 2024
@andrewseguin andrewseguin removed the request for review from a team July 3, 2024 18:00
@andrewseguin andrewseguin merged commit 1f992d0 into angular:main Jul 3, 2024
20 of 22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
2 participants
@DBowen33 @andrewseguin