fix(material/bottom-sheet): changed after checked error with zoneless #29277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that when closing and immediately reopening bottom sheet in a zoneless app, we were causing a "changed after checked" error to be thrown. It seems to be because we were calling `detectChanges` without marking for check first. Fixes angular#29258.
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
crisbeto
commented
Jun 18, 2024
| @@ -92,15 +92,17 @@ export class MatBottomSheetContainer extends CdkDialogContainer implements OnDes | |||
| this._breakpointSubscription = breakpointObserver | |||
| .observe([Breakpoints.Medium, Breakpoints.Large, Breakpoints.XLarge]) | |||
| .subscribe(() => { | |||
| this._toggleClass( | |||
| const classList = (this._elementRef.nativeElement as HTMLElement).classList; | |||
|
|
|||
There was a problem hiding this comment.
This change is unrelated to the fix, I just figured it's a good chance for a cleanup.
amysorto
approved these changes
Jun 18, 2024
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
…angular#29277) Fixes that when closing and immediately reopening bottom sheet in a zoneless app, we were causing a "changed after checked" error to be thrown. It seems to be because we were calling `detectChanges` without marking for check first. Fixes angular#29258.
This was referenced Jul 12, 2024
This was referenced Jul 15, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that when closing and immediately reopening bottom sheet in a zoneless app, we were causing a "changed after checked" error to be thrown. It seems to be because we were calling
detectChangeswithout marking for check first.Fixes #29258.