Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared-docs): remove custom id from heading label #2196

Closed
wants to merge 1 commit into from
Closed

fix(shared-docs): remove custom id from heading label #2196

wants to merge 1 commit into from

Conversation

lacolaco
Copy link
Contributor

@lacolaco lacolaco changed the title fix: remove custom id from heading content fix: remove custom id from heading label Jul 23, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jul 23, 2024
@lacolaco lacolaco changed the title fix: remove custom id from heading label fix(docs): remove custom id from heading label Jul 23, 2024
@lacolaco lacolaco marked this pull request as ready for review July 23, 2024 02:37
@angular-robot angular-robot bot added area: docs Related to the documentation and removed area: docs Related to the documentation labels Jul 23, 2024
@angular-robot angular-robot bot removed the area: docs Related to the documentation label Jul 23, 2024
@lacolaco lacolaco changed the title fix(docs): remove custom id from heading label fix(shared-docs): remove custom id from heading label Jul 23, 2024
@lacolaco
Copy link
Contributor Author

lacolaco commented Jul 24, 2024 •
edited
Loading

Thank you for reviewing. I hope this fix will be quickly picked up by angular/angular, as this issue is a critical blocker in adev translations.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jul 24, 2024
@josephperrott
Copy link
Member

This PR was merged into the repository by commit cf5026f.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: explicit header ID should be removed from heading label
3 participants
@lacolaco @josephperrott @JeanMeche