Skip to content
This repository has been archived by the owner on Apr 9, 2022. It is now read-only.

feat(@ngtools/webpack): add support for multiple entry modules #875

Closed
wants to merge 1 commit into from
Closed

feat(@ngtools/webpack): add support for multiple entry modules #875

wants to merge 1 commit into from

Conversation

artonge
Copy link

@artonge artonge commented May 9, 2018

When the webpack config is building two different apps from two
entry points, one of the apps will not work because metadatas are not
generated. The commit add a new property (entryModules) in
AngularCompilerPluginOptions that permit to regsiter multiple entry
modules.

Fix #861

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

When the webpack config is building two different apps from two
entry points, one of the apps will not work because metadatas are not
generated. The commit add a new property (entryModules) in
AngularCompilerPluginOptions that permit to regsiter multiple entry
modules
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 9, 2018
@artonge
Copy link
Author

artonge commented May 9, 2018

Working example in this repo on the working_example branch.

@artonge
Copy link
Author

artonge commented May 11, 2018

npm run test-large failed for unknown reason. Can a maintainer help sorting this out ?

@filipesilva
Copy link
Contributor

Please see my response on #861 (comment) as to why we do not want to add this right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants