This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(match-media): unregister media query event listeners on destroy #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
force-pushed
the
adam/fix-issue-1213
branch
2 times, most recently
from
39fc087 to
524a799
Compare
JoostK
suggested changes
May 10, 2020
CaerusKaru
force-pushed
the
adam/fix-issue-1213
branch
2 times, most recently
from
3ca1544 to
feae404
Compare
JoostK
reviewed
May 11, 2020
When the internal registry of media query listeners is reset, or MatchMedia is destroyed, the listeners themselves are not currently being removed. This leads to memory leaks, which is corrected by this commit. Fixes #1213
CaerusKaru
force-pushed
the
adam/fix-issue-1213
branch
from
feae404 to
ee0d689
Compare
JoostK
approved these changes
May 11, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the internal registry of media query listeners is reset, or
MatchMedia is destroyed, the listeners themselves are not currently
being removed. This leads to memory leaks, which is corrected by
this commit.
Fixes #1213