This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(core): reset current value when directive is cleared #1376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a directive is fired, it sets a current value to compare to
future values, that way we don't fire mutiple costly element
change events per media update. However, when a directive moves
to an "uncovered" segment, ie a segment where there is no active
value, we are not clearing the previous current value. This leads
to a lack of updates when styles are not present but should be,
e.g. when a directive moves into an uncovered segment, and then
back into a covered one.
Therefore, we reset the currentValue for a directive when we clear
styles, to enable updates when moving back to a covered segment
later.
Fixes #1291