Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix(fxLayoutGap): not working with dynamic fxHide #983

Merged
merged 3 commits into from
Jan 13, 2019
Merged

Conversation

CaerusKaru
Copy link
Member

No description provided.

@CaerusKaru
Copy link
Member Author

The root cause analysis on this is tricky. The reason this happens is that the fxLayoutGap doesn't pick up changes to the show-hide value, because show-hide hasn't fired yet. So instead it picks up the old value.

Therefore we need to devise a method in which dynamic changes trigger new updates correctly. Maybe not tricky, but potentially tedious.

@CaerusKaru CaerusKaru added in-progress P1 Urgent issue that should be resolved before the next re-lease pr: needs review and removed in-progress labels Jan 13, 2019
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Jan 13, 2019
@CaerusKaru CaerusKaru changed the title WIP fix(fxLayoutGap): not working with dynamic fxHide fix(fxLayoutGap): not working with dynamic fxHide Jan 13, 2019
@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer and removed pr: needs review labels Jan 13, 2019
@ThomasBurleson ThomasBurleson merged commit 0eccec4 into master Jan 13, 2019
@CaerusKaru CaerusKaru deleted the adam/gap branch January 13, 2019 22:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes P1 Urgent issue that should be resolved before the next re-lease pr: lgtm This PR has been approved by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants