This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(core): MediaObserver can report 1..n activations #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
thomas/fix-media-observer
branch
2 times, most recently
from
1b81cff to
be51588
Compare
ThomasBurleson
force-pushed
the
thomas/fix-media-observer
branch
from
be51588 to
476521f
Compare
|
@CaerusKaru - ready for review. |
CaerusKaru
suggested changes
Jan 15, 2019
src/apps/demo-app/src/app/media-query-status/media-query-status.component.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** HOF to sort the breakpoints by priority */ | ||
| export function sortChangesByPriority(a: MediaChange, b: MediaChange): number { |
There was a problem hiding this comment.
Isn't this exported somewhere else?
There was a problem hiding this comment.
Different data types.
There was a problem hiding this comment.
Can we make the original a generic?
ThomasBurleson
force-pushed
the
thomas/fix-media-observer
branch
3 times, most recently
from
34df933 to
89ecba8
Compare
Previous versions of MediaObserver suffered from a significant design-flaw. Those versions assumed that a breakpoint change would only activate/match a single mediaQuery. Additionally those versions would not (by default) report overlapping activations. Applications interested in notifications for all current activations would therefore not receive proper event-notifications. The current enhancements provide several features: * Report 1..n mediaQuery activations (matches == true) in a single event * Report activations sorted by descending priority * By default, reports include overlapping breakpoint activations * Debounce notifications to a single grouped event > useful to reduce browser reflow thrashing Developers should note that while `media$: Observable< MediaChange >`, the `asObservable()` emits arrays: `Observable< MediaChange[] >`. BREAKING CHANGE: * `filterOverlaps` now defaults to `false`
ThomasBurleson
force-pushed
the
thomas/fix-media-observer
branch
from
89ecba8 to
341d13b
Compare
|
CaerusKaru
approved these changes
Jan 15, 2019
CaerusKaru
added
pr: lgtm
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of MediaObserver suffered from a significant design-flaw.
Those versions assumed that a breakpoint change would only activate/match a single mediaQuery. Additionally those versions would not (by default) report overlapping activations. Applications interested in notifications for all current activations would therefore not receive proper event-notifications.
The current enhancements provide several features:
BREAKING CHANGE:
The stream data type is now MediaChange[] instead of MediaChange and
media$is deprecated in favor ofasObservable().filterOverlapsnow defaults tofalsemedia$is now aObservable< MediaChange[] >instead ofObservable< MediaChange >