fix(style): apply correct flex with ngStyle and layout change #733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #700
For this issue, I found that the flex is initialized to '1 1 0%', when the layout changes, the layout event triggers before ngStyle, so invokes
_updateStyle
to apply this initialization to thengStyleBase
. Then for the followingngStyle.lt-md
event, just merge this base style.So the change is: when the
input
changes in theStyleDirective
, check the base style, if it's not same with the current style, replace it with the current style and for others which have been merged withngStyleBase
, delete the corresponding style and merge again.In the following test cases, the first case is just like the scenario in the #700