fix(panel): updates to positioning

Author: ErinCoughlan

src/components/panel/demoBasicUsage/panel.tmpl.html

@@ -16,9 +16,6 @@ <h2>Surprise!</h2>
   </div>
 
   <div layout="row" class="demo-dialog-button">
-    <md-button flex class="md-primary">
-      Nothing
-    </md-button>
     <md-button md-autofocus flex class="md-primary" ng-click="ctrl.closeDialog()">
       Close
     </md-button>

src/components/panel/demoPanelAnimations/panel.tmpl.html

@@ -16,9 +16,6 @@ <h2>Surprise!</h2>
   </div>
 
   <div layout="row" class="demo-dialog-button">
-    <md-button flex class="md-primary">
-      Nothing
-    </md-button>
     <md-button md-autofocus flex class="md-primary" ng-click="ctrl.closeDialog()">
       Close
     </md-button>

src/components/panel/panel.js

@@ -1104,10 +1104,11 @@ MdPanelRef.prototype._addStyles = function() {
     // correctly. This is necessary so that the panel will have a defined height
     // and width.
     self._$rootScope['$$postDigest'](function() {
-      self._panelEl.css('top', positionConfig.getTop(self._panelEl));
-      self._panelEl.css('bottom', positionConfig.getBottom(self._panelEl));
-      self._panelEl.css('left', positionConfig.getLeft(self._panelEl));
-      self._panelEl.css('right', positionConfig.getRight(self._panelEl));
+      positionConfig._calculatePanelPosition(self._panelEl);
+      self._panelEl.css('top', positionConfig.getTop());
+      self._panelEl.css('bottom', positionConfig.getBottom());
+      self._panelEl.css('left', positionConfig.getLeft());
+      self._panelEl.css('right', positionConfig.getRight());
 
       // Use the vendor prefixed version of transform.
       var prefixedTransform = self._$mdConstant.CSS.TRANSFORM;
@@ -1412,9 +1413,6 @@ function MdPanelPosition() {
   /** @private {!DOMRect} */
   this._relativeToRect;
 
-  /** @private {boolean} */
-  this._panelPositionCalculated = false;
-
   /** @private {string} */
   this._top = '';
 
@@ -1677,44 +1675,36 @@ MdPanelPosition.prototype.withOffsetY = function(offsetY) {
 
 /**
  * Gets the value of `top` for the panel.
- * @param {!angular.JQLite} panelEl
  * @returns {string}
  */
-MdPanelPosition.prototype.getTop = function(panelEl) {
-  this._calculatePanelPosition(panelEl);
+MdPanelPosition.prototype.getTop = function() {
   return this._top;
 };
 
 
 /**
  * Gets the value of `bottom` for the panel.
- * @param {!angular.JQLite} panelEl
  * @returns {string}
  */
-MdPanelPosition.prototype.getBottom = function(panelEl) {
-  this._calculatePanelPosition(panelEl);
+MdPanelPosition.prototype.getBottom = function() {
   return this._bottom;
 };
 
 
 /**
  * Gets the value of `left` for the panel.
- * @param {!angular.JQLite} panelEl
  * @returns {string}
  */
-MdPanelPosition.prototype.getLeft = function(panelEl) {
-  this._calculatePanelPosition(panelEl);
+MdPanelPosition.prototype.getLeft = function() {
   return this._left;
 };
 
 
 /**
  * Gets the value of `right` for the panel.
- * @param {!angular.JQLite} panelEl
  * @returns {string}
  */
-MdPanelPosition.prototype.getRight = function(panelEl) {
-  this._calculatePanelPosition(panelEl);
+MdPanelPosition.prototype.getRight = function() {
   return this._right;
 };
 
@@ -1735,7 +1725,7 @@ MdPanelPosition.prototype.getTransform = function() {
 
 /**
  * Gets the first x/y position that can fit on-screen.
- * @returns {string}
+ * @returns {{x: string, y: string}}
  */
 MdPanelPosition.prototype.getActualPosition = function() {
   // TODO(gmoothart): intelligently pick the first on-screen position.
@@ -1766,16 +1756,13 @@ MdPanelPosition.prototype._reduceTranslateValues =
  */
 MdPanelPosition.prototype._calculatePanelPosition = function(panelEl) {
   // Only calculate the position if necessary.
-  if (this._absolute || this._panelPositionCalculated) {
+  if (this._absolute) {
     return;
   }
 
   // TODO(ErinCoughlan): Update position on scroll.
   // TODO(ErinCoughlan): Position panel intelligently to keep it on screen.
 
-  // Indicate that the position is calculated so it can be skipped next time.
-  this._panelPositionCalculated = true;
-
   var panelBounds = panelEl[0].getBoundingClientRect();
   var panelWidth = panelBounds.width;
   var panelHeight = panelBounds.height;