Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 02d3de2

Browse files
devversionThomasBurleson
authored andcommitted
fix(radioButton): demos are not support RTL properly.
* Currently the radioButton demo is only querying for a dir attribute on the HTML, but that is not consistent with our RTL mixins. Additionally, these query is not necessary, because we can just apply on right and left a padding and the demo will look great on RTL as well. Also it will wrap the text of the demo property in LTR and RTL. Fixes #8233. Closes #8243
1 parent a8473e9 commit 02d3de2

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

src/components/radioButton/demoBasicUsage/index.html

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div>
2-
<form ng-submit="submit()" ng-controller="AppCtrl" class="bidi" ng-cloak>
2+
<form ng-submit="submit()" ng-controller="AppCtrl" ng-cloak>
33
<p>Selected Value: <span class="radioValue">{{ data.group1 }}</span> </p>
44

55
<md-radio-group ng-model="data.group1">
@@ -51,12 +51,3 @@
5151
</md-radio-group>
5252
</form>
5353
</div>
54-
55-
<style>
56-
57-
html[dir="rtl"] .bidi {
58-
padding-right: 20px;
59-
padding-left:0;
60-
}
61-
62-
</style>

src/components/radioButton/demoBasicUsage/style.css

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ body {
44
}
55

66
hr {
7-
margin-left:-20px; opacity:0.3;
7+
margin-left: -20px;
8+
opacity: 0.3;
89
}
910

1011
md-radio-group {
11-
width:150px;
12+
width: 150px;
1213
}
1314

1415
p:last-child {
@@ -17,7 +18,7 @@ p:last-child {
1718

1819

1920
[ng-controller] {
20-
padding-left: 20px;
21+
padding: 0 20px;
2122
}
2223

2324
.radioValue {
@@ -29,10 +30,9 @@ p:last-child {
2930
}
3031

3132
md-icon {
32-
margin: 20px;
33-
margin-top: 0;
34-
width: 128px;
35-
height: 128px;
33+
margin: 0 20px 20px;
34+
width: 128px;
35+
height: 128px;
3636
}
3737

3838

0 commit comments

Comments
 (0)