Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 5d9f960

Browse files
arushThomasBurleson
authored andcommitted
fix(layout): resolve incorrect and duplicate layout tests
There were a number of typos and incorrect combinations of values in the alignmentValues array that didn't correspond to the layout.scss causing incorrect tests to be run. There were also duplicates, there were 31 values, now 19. Closes #4740.
1 parent 7264cab commit 5d9f960

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/core/services/layout/layout.spec.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,11 @@ describe('layout directives', function() {
1414
var flexValues = [0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 100, 33, 34, 66, 67];
1515
var offsetValues = [5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 33, 34, 66, 67];
1616
var alignmentValues = [
17-
'center', 'center center', 'center start', 'center end',
18-
'end', 'end-center', 'end start', 'end end',
19-
'space-around', 'space-around center', 'space-around start', 'space-around end',
20-
'space-between', 'space-between center', 'space-between start', 'space-between end',
21-
'center center', 'start center', 'end center', 'space-between center', 'space-around center',
22-
'center start', 'start start', 'end start', 'space-between start', 'space-around start',
23-
'center end', 'start end', 'end end', 'space-between end', 'space-around end'
24-
];
17+
"center", "center center", "center start", "center end",
18+
"end", "end center", "end start", "end end",
19+
"space-around", "space-around center", "space-around start", "space-around end",
20+
"space-between", "space-between center", "space-between start", "space-between end",
21+
"start center", "start start", "start end"];
2522
var mappings = [
2623
{ attribute: 'flex', suffixes: suffixes, values: flexValues, addDirectiveAsClass: true, testStandAlone: true},
2724
{ attribute: 'flex-order', suffixes: suffixes, values: flexOrderValues },

0 commit comments

Comments
 (0)