Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 7a15750

Browse files
Nissan HaninaThomasBurleson
authored andcommitted
fix(input): IE perf with attribute selectors for ngMessages
IE manifest huge performance issues with attribute selectors. Reproduce this very easily using `UI Responsivess` tab in IE11 developer tools: * duplicate the amount of ` :not` selectors prefixed with space and * measure the time it takes for IE to calculate layout(in green). Closes #7360
1 parent b58343c commit 7a15750

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/components/input/demoErrors/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
</div>
6060
</md-input-container>
6161

62-
<p>
62+
<p style="font-size:.8em; width: 100%; text-align: center;">
6363
Make sure to include <a href="https://docs.angularjs.org/api/ngMessages" target="_blank">ngMessages</a> module when using ng-message markup.
6464
</p>
6565
</form>

src/components/input/input-theme.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@ md-input-container.md-THEME_NAME-theme {
2828
ng-message, data-ng-message, x-ng-message,
2929
[ng-message], [data-ng-message], [x-ng-message],
3030
[ng-message-exp], [data-ng-message-exp], [x-ng-message-exp] {
31-
:not(.md-char-counter) {
32-
color: '{{warn-A700}}';
31+
color: '{{warn-A700}}';
32+
.md-char-counter {
33+
color: '{{foreground-1}}';
3334
}
3435
}
3536

0 commit comments

Comments
 (0)