Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 7a98d7b

Browse files
devversionThomasBurleson
authored andcommitted
fix(input): fix invalid animation for input.
At the moment the animation will stuck if there is no `md-auto-hide` class or the class isn't `md-input-invalid`. That's because we not trigger the callback if we finish the animation. Fixes #6822. Closes #6880
1 parent 64911ab commit 7a98d7b

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

src/components/input/demoErrors/index.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@
5656
{{projectForm.rate.$viewValue | currency:"$":0}} an hour? That's a little ridiculous. I
5757
doubt event Bill Clinton could afford that.
5858
</div>
59-
60-
Make sure to include <a href="https://docs.angularjs.org/api/ngMessages" target="_blank">angular-messages</a> module when using ng-message.
6159
</div>
60+
<p>
61+
Make sure to include <a href="https://docs.angularjs.org/api/ngMessages" target="_blank">ngMessages</a> module when using ng-message markup.
62+
</p>
6263
</md-input-container>
6364
</form>
6465
</md-content>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,8 @@
11
.inputErrorsApp { min-height:48px; }
2+
3+
4+
md-input-container > p {
5+
font-size: 0.8em;
6+
text-align: left;
7+
width:100%;
8+
}

src/components/input/input.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,8 @@ function mdInputInvalidMessagesAnimation($q, $animateCss) {
615615

616616
if (className == "md-input-invalid" && messages.hasClass('md-auto-hide')) {
617617
showInputMessages(element, $animateCss, $q).finally(done);
618+
} else {
619+
done();
618620
}
619621
}
620622

0 commit comments

Comments
 (0)