Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 8b210c3

Browse files
fix(layout): device size attributes should not set max-width or max-height
do not specify max-height or max-width for **.layout-column** and **.layout-row** media breakpoints; as these incorrectly limited the size of the container. > Consider below where `<xxx>` is the display breakpoints sm, md, lg, gt-sm, etc. Breaking Changes Before ```css .layout-colum > .flex-<xxx> { max-height : <percentage>; } .layout-row > .flex-<xxx> { max-width : <percentage>; } ``` now ```css .layout-colum > .flex-<xxx> { } .layout-row > .flex-<xxx> { } ```
1 parent 65d0db5 commit 8b210c3

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

src/core/services/layout/layout.scss

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -157,36 +157,25 @@
157157
.#{$flexName}-#{$i * 5} {
158158
flex: 0 0 #{$i * 5 + '%'};
159159
}
160-
.layout-row > .#{$flexName}-#{$i * 5} {
161-
max-width: #{$i * 5 + '%'};
162-
}
163-
.layout-column > .#{$flexName}-#{$i * 5} {
164-
max-height: #{$i * 5 + '%'};
165-
}
160+
.layout-row > .#{$flexName}-#{$i * 5} { }
161+
.layout-column > .#{$flexName}-#{$i * 5} { }
166162
}
167163

168164
.#{$flexName}-33, .#{$flexName}-34 {
169-
flex: 0 0 33.33%;
165+
flex: 0 0 34%;
170166
}
171167
.#{$flexName}-66, .#{$flexName}-67 {
172-
flex: 0 0 66.66%;
168+
flex: 0 0 66%;
169+
173170
}
174171

175172
.layout-row {
176-
> .#{$flexName}-33, > .#{$flexName}-34 {
177-
max-width: 33.33%;
178-
}
179-
> .#{$flexName}-66, > .#{$flexName}-67 {
180-
max-width: 66.66%;
181-
}
173+
> .#{$flexName}-33, > .#{$flexName}-34 { }
174+
> .#{$flexName}-66, > .#{$flexName}-67 { }
182175
}
183176
.layout-column {
184-
> .#{$flexName}-33, > .#{$flexName}-34 {
185-
max-height: 33.33%;
186-
}
187-
> .#{$flexName}-66, > .#{$flexName}-67 {
188-
max-height: 66.66%;
189-
}
177+
> .#{$flexName}-33, > .#{$flexName}-34 { }
178+
> .#{$flexName}-66, > .#{$flexName}-67 { }
190179
}
191180
}
192181

0 commit comments

Comments
 (0)