Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 8d7f54f

Browse files
EladBezalelThomasBurleson
authored andcommitted
fix(bidi-demos): fixed broken demos
- fixed `rtl-prop` mixin to override `ltr` property when applied - fixed checkbox demos - fixed datepicker triangle alignment - fixed divider demos - fixed inset divider in list - fixed tooltip demos fixes #7399 Closes #7409
1 parent fae559c commit 8d7f54f

File tree

9 files changed

+20
-39
lines changed

9 files changed

+20
-39
lines changed

src/components/checkbox/demoBasicUsage/style.css

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ div.flex-xs {
55
.checkboxDemo1 div {
66
clear: both;
77
}
8-
.checkboxDemo1 md-checkbox {
9-
float: left;
10-
}
8+
119
p {
1210
padding-left: 8px;
1311
}

src/components/checkbox/demoSyncing/style.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
.checkboxDemo1 div {
22
clear: both;
33
}
4-
.checkboxDemo1 md-checkbox {
5-
float: left;
6-
}
74
legend {
85
color: #3F51B5;
96
}

src/components/datepicker/datePicker.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ $md-date-arrow-size: 5px;
137137
top: 0;
138138

139139
// TODO(jelbourn): This position isn't great on all platforms.
140-
transform: translateY(-25%) translateX(45%);
140+
@include rtl(transform, translateY(-25%) translateX(45%), translateY(-25%) translateX(-45%));
141141
}
142142

143143
// Need crazy specificity to override .md-button.md-icon-button.

src/components/divider/demoBasicUsage/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ <h2 class="md-toolbar-tools">
2929
<md-content>
3030
<md-list>
3131
<md-list-item class="md-3-line" ng-repeat="item in messages">
32-
<img ng-src="{{item.face}}?{{$index}}" class="face" alt="{{item.who}}">
32+
<img ng-src="{{item.face}}?{{$index}}" class="md-avatar" alt="{{item.who}}">
3333
<div class="md-list-item-text">
3434
<h3>{{item.what}}</h3>
3535
<h4>{{item.who}}</h4>

src/components/divider/demoBasicUsage/style.css

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/components/list/list.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ md-list-item {
201201
&[md-inset] {
202202
@include rtl-prop(left, right, $list-item-inset-divider-offset);
203203
width: calc(100% - #{$list-item-inset-divider-offset});
204-
margin: 0;
204+
margin: 0 !important;
205205
}
206206
}
207207

src/components/tooltip/demoBasicUsage/index.html

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,20 @@ <h2 class="md-toolbar-tools">
1919
The tooltip is visible when the button is hovered, focused, or touched.
2020
</p>
2121

22-
<md-button class="md-fab" aria-label="Insert Drive">
23-
<md-icon md-svg-src="img/icons/ic_insert_drive_file_24px.svg"></md-icon>
24-
<md-tooltip md-visible="demo.showTooltip" md-direction="{{demo.tipDirection}}">
25-
Insert Drive
26-
</md-tooltip>
27-
</md-button>
28-
<md-button class="md-fab md-fab-top-right right" aria-label="Photos">
29-
<md-tooltip>
30-
Photos
31-
</md-tooltip>
32-
<md-icon md-svg-src="img/icons/ic_photo_24px.svg" style="width: 24px; height: 24px;"></md-icon>
33-
</md-button>
22+
<div layout="row" layout-align="space-between">
23+
<md-button class="md-fab" aria-label="Insert Drive">
24+
<md-icon md-svg-src="img/icons/ic_insert_drive_file_24px.svg"></md-icon>
25+
<md-tooltip md-visible="demo.showTooltip" md-direction="{{demo.tipDirection}}">
26+
Insert Drive
27+
</md-tooltip>
28+
</md-button>
29+
<md-button class="md-fab" aria-label="Photos">
30+
<md-tooltip>
31+
Photos
32+
</md-tooltip>
33+
<md-icon md-svg-src="img/icons/ic_photo_24px.svg" style="width: 24px; height: 24px;"></md-icon>
34+
</md-button>
35+
</div>
3436

3537

3638
<div style="margin-top: 40px;margin-bottom: -5px">

src/components/tooltip/demoBasicUsage/style.css

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,4 @@ md-toolbar .md-toolbar-tools .md-button:hover {
55
border: none;
66
transform: none;
77
-webkit-transform: none;
8-
}
9-
10-
11-
.left {
12-
top:70px !important;
13-
left:56px !important;
14-
}
15-
16-
.right {
17-
top:70px !important;
18-
right:56px !important;
19-
}
8+
}

src/core/style/mixins.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
@mixin rtl-prop($ltr-prop, $rtl-prop, $value) {
115115
#{$ltr-prop}: $value;
116116
[dir=rtl] & {
117+
#{$ltr-prop}: auto;
117118
#{$rtl-prop}: $value;
118119
}
119120
}

0 commit comments

Comments
 (0)