Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit ae7d661

Browse files
devversionThomasBurleson
authored andcommitted
fix(dialog): fix dialog resizing on window resize
The current resize listeners for the window are misplaced inside of the condition of `escapeToClose == true`. Fixes #6876 Closes #6878
1 parent d963dca commit ae7d661

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/components/dialog/dialog.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -746,17 +746,23 @@ function MdDialogProvider($$interimElementProvider) {
746746
// Add keydown listeners
747747
element.on('keydown', keyHandlerFn);
748748
target.on('keydown', keyHandlerFn);
749-
window.on('resize', onWindowResize);
750749

751750
// Queue remove listeners function
752751
removeListeners.push(function() {
753752

754753
element.off('keydown', keyHandlerFn);
755754
target.off('keydown', keyHandlerFn);
756-
window.off('resize', onWindowResize);
757755

758756
});
759757
}
758+
759+
// Register listener to update dialog on window resize
760+
window.on('resize', onWindowResize);
761+
762+
removeListeners.push(function() {
763+
window.off('resize', onWindowResize);
764+
});
765+
760766
if (options.clickOutsideToClose) {
761767
var target = element;
762768
var sourceElem;

0 commit comments

Comments
 (0)