Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit d6a938e

Browse files
Robert MesserleThomasBurleson
authored andcommitted
fix(select): interimElement will resolve its promise even when transition end event is not fired
Occassionally the transitionEnd event will not fire and the '$mdUtil. waitTransitionEnd()' process will timeout; which rejects the pending promise. Using '.finally()' allows the correct handlers to fire and will continuing to propagate the rejected promise. Fixes #3704. Fixes #3780. Fixes #3800. Closes #3794.
1 parent 171b7ed commit d6a938e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/core/services/interimElement/interimElement.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ function InterimElementProvider() {
412412
},
413413
remove: function() {
414414
self.cancelTimeout();
415-
return removeDone = $q.when(showDone).then(function() {
415+
return removeDone = $q.when(showDone).finally(function() {
416416
var ret = element ? options.onRemove(options.scope, element, options) : true;
417417

418418
// Trigger onRemoving callback *before* the remove operation starts

0 commit comments

Comments
 (0)