fix(select): select no longer overflows window, resizes from small to big correctly

rschmukler · rschmukler · commit ee4ab189abe4 · 2015-11-19T20:00:46.000-05:00
closes #5291
diff --git a/src/components/select/select.js b/src/components/select/select.js
@@ -1317,6 +1317,8 @@ function SelectProvider($$interimElementProvider) {
 
       if (contentNode.offsetWidth > maxWidth) {
         contentNode.style['max-width'] = maxWidth + 'px';
+      } else {
+        contentNode.style.maxWidth = null;
       }
       if (shouldOpenAroundTarget) {
         contentNode.style['min-width'] = targetRect.width + 'px';
@@ -1379,7 +1381,7 @@ function SelectProvider($$interimElementProvider) {
         transformOrigin = (centeredRect.left + targetRect.width / 2) + 'px ' +
           (centeredRect.top + centeredRect.height / 2 - contentNode.scrollTop) + 'px 0px';
 
-        minWidth = targetRect.width + centeredRect.paddingLeft + centeredRect.paddingRight;
+        minWidth = Math.min(targetRect.width + centeredRect.paddingLeft + centeredRect.paddingRight, maxWidth);
       }
 
       // Keep left and top within the window

Original file line number	Diff line number	Diff line change
`@@ -1317,6 +1317,8 @@ function SelectProvider($$interimElementProvider) {`
`1317`	`1317`
`1318`	`1318`	`if (contentNode.offsetWidth > maxWidth) {`
`1319`	`1319`	`contentNode.style['max-width'] = maxWidth + 'px';`
	`1320`	`+ } else {`
	`1321`	`+ contentNode.style.maxWidth = null;`
`1320`	`1322`	`}`
`1321`	`1323`	`if (shouldOpenAroundTarget) {`
`1322`	`1324`	`contentNode.style['min-width'] = targetRect.width + 'px';`
`@@ -1379,7 +1381,7 @@ function SelectProvider($$interimElementProvider) {`
`1379`	`1381`	`transformOrigin = (centeredRect.left + targetRect.width / 2) + 'px ' +`
`1380`	`1382`	`(centeredRect.top + centeredRect.height / 2 - contentNode.scrollTop) + 'px 0px';`
`1381`	`1383`
`1382`		`- minWidth = targetRect.width + centeredRect.paddingLeft + centeredRect.paddingRight;`
	`1384`	`+ minWidth = Math.min(targetRect.width + centeredRect.paddingLeft + centeredRect.paddingRight, maxWidth);`
`1383`	`1385`	`}`
`1384`	`1386`
`1385`	`1387`	`// Keep left and top within the window`