Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit faf5845

Browse files
fix(layout): Firefox and flex layout with min-height
* while Chrome has fixed this bug, Firefox still needs this workaround. Fixes #7382.
1 parent 6411cc4 commit faf5845

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

src/core/style/layout.scss

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,9 @@
141141
max-width: #{$value};
142142
max-height: 100%;
143143
box-sizing: border-box;
144+
145+
// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
146+
@if $i == 0 { min-width: 0; }
144147
}
145148

146149
.layout-column > .#{$flexName}-#{$i * 5},
@@ -149,18 +152,27 @@
149152
max-width: 100%;
150153
max-height: #{$value};
151154
box-sizing: border-box;
152-
}
153155

156+
// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
157+
@if $i == 0 { min-height: 0; }
158+
}
154159

155160
}
156161

157162
.layout-row, .layout#{$name}-row {
158163
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33.33%; max-width: 33.33%; max-height: 100%; box-sizing: border-box; }
159164
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66.66%; max-width: 66.66%; max-height: 100%; box-sizing: border-box; }
165+
166+
// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
167+
> .flex { min-width: 0; }
168+
160169
}
161170
.layout-column, .layout#{$name}-column {
162171
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33.33%; max-width: 100%; max-height: 33.33%; box-sizing: border-box; }
163172
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66.66%; max-width: 100%; max-height: 66.66%; box-sizing: border-box; }
173+
174+
// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
175+
> .flex { min-height: 0; }
164176
}
165177

166178
}

0 commit comments

Comments
 (0)