Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

nnmrts
Copy link
Contributor

@nnmrts nnmrts commented Dec 2, 2016

feat(input): add animation to color change

add animation to color change when clicking inside an md-input field
previous behaviour was an instant color change, which doesn't harmonize with material design guidelines

hansl and others added 2 commits September 2, 2016 12:15
feat(input): add animation to color change

add animation to color change when clicking inside an `md-input` field
previous behaviour was an instant color change, which doesn't harmonize with material design guidelines
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Dec 2, 2016
@nnmrts
Copy link
Contributor Author

nnmrts commented Dec 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Dec 2, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 1, 2017
@clshortfuse clshortfuse self-assigned this Jan 9, 2017
@clshortfuse
Copy link
Contributor

@nnmrts Do you have a source for these bezier curve numbers?

@nnmrts
Copy link
Contributor Author

nnmrts commented Jan 14, 2017

@clshortfuse actually not, just used a random bezier curve, but perhaps we can use some of these: https://material.io/archive/guidelines/motion/duration-easing.html#duration-easing-natural-easing-curves

@angular angular deleted a comment from googlebot May 1, 2020
@angular angular deleted a comment from googlebot May 1, 2020
@Splaktar Splaktar assigned Splaktar and unassigned clshortfuse May 1, 2020
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the input spec, there does appear to be an animation of the colors coming in, but it seems to go a step farther with the color changing via a ripple.

After testing this locally, I think that animating the color change is a good first step. I don't think that we'll get to the point of changing the color via a ripple.

So this LGTM once it's updated to use our variables for the duration and curve.

@Splaktar Splaktar modified the milestones: Future, 1.1.23 May 1, 2020
@Splaktar Splaktar requested a review from jelbourn May 1, 2020 01:17
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: spec alignment For issues related to aligning with the Material Design Spec labels May 1, 2020
@Splaktar
Copy link
Contributor

Splaktar commented May 1, 2020

This build is failing because we switched from TravisCI to CircleCI. Rebasing the PR would resolve that, but it doesn't need to be rebased to merge this one line change.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar changed the base branch from release/1.1.1 to master May 1, 2020 16:42
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ labels May 1, 2020
@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed pr: merge ready This PR is ready for a caretaker to review labels May 1, 2020
@Splaktar
Copy link
Contributor

Splaktar commented May 1, 2020

@googlebot I consent.

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels May 1, 2020
@Splaktar Splaktar merged commit b486a41 into angular:master May 1, 2020
@nnmrts
Copy link
Contributor Author

nnmrts commented May 26, 2020

Wow. After all these years.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ hotlist: animations P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: spec alignment For issues related to aligning with the Material Design Spec ux: polish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants