This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(menu): avoid runtime errors when menu-content isn't set. #10198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer throws runtime exceptions in the $mdMenu service when no `md-menu-content` element is specified. > When the `$mdMenu` service is used programmatically it will show a warning and just doesn't setup the interaction. When the `md-menu` directive misses the `md-menu-content` element a normal error will be thrown, so developers can detect before actually opening the menu, that the `md-menu-content` element is missing. Fixes angular#9709.
googlebot
added
the
cla: yes
devversion
added
in progress
devversion
force-pushed
the
fix/menu-content-element
branch
from
d888527 to
3921908
Compare
devversion
added
needs: review
ThomasBurleson
added
needs: presubmit
and removed
needs: review
|
lgtm |
kara
added
pr: merge ready
davidenochk
pushed a commit
to davidenochk/material
that referenced
this pull request
Feb 3, 2017
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer throws runtime exceptions in the $mdMenu service when no
md-menu-contentelement is specified.When the
md-menudirective misses themd-menu-contentelement a normal error will be thrown, so developers can detect before actually opening the menu, that themd-menu-contentelement is missing.Fixes #9709.