This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): don't override initial model value #10273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Looks like this fails against Angular 1.5, but works against 1.6. Will investigate. |
Fixes an issue, introduced in angular#9945, that caused the select to override the initial model value.
crisbeto
force-pushed
the
select-initial-value-override
branch
from
aaf4587 to
2b41ab2
Compare
|
Fixed. It was an issue with the unit test. |
jelbourn
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
davidenochk
pushed a commit
to davidenochk/material
that referenced
this pull request
Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue, introduced in #9945, that caused the select to override the initial model value.
CC @jelbourn