Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(panel): fix propagateContainerEvents #10497

Merged
merged 1 commit into from
May 9, 2017

Conversation

GuyPie
Copy link
Contributor

@GuyPie GuyPie commented Mar 15, 2017

Change $mdPanel with propagateContainerEvents set to true to not close when it is clicked. #GoodnessSquad

Fixes: #10495

Change $mdPanel with propagateContainerEvents set to true to not close when it is clicked.

Fixes: angular#10495
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 15, 2017
@GuyPie
Copy link
Contributor Author

GuyPie commented Mar 15, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 15, 2017
@EladBezalel
Copy link
Member

@ErinCoughlan can you please take a look ? :)

Copy link
Contributor

@ErinCoughlan ErinCoughlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone May 8, 2017
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels May 9, 2017
@kara kara merged commit 281504f into angular:master May 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$mdPanel - propagateContainerEvents causes clicks on the panel to close it
6 participants