Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

du6
Copy link
Contributor

@du6 du6 commented Mar 21, 2017

Fixes #10510

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 21, 2017
@du6 du6 changed the title fix(input): Fix placeholder text being read twice by screen readers. #10510 fix(input): Fix placeholder text being read twice by screen readers. Mar 21, 2017
@du6
Copy link
Contributor Author

du6 commented Mar 21, 2017

I signed it!

@ThomasBurleson
Copy link
Contributor

@du6 - still see it as unsigned.

@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone May 8, 2017
@ThomasBurleson
Copy link
Contributor

@crisbeto - can you review?

@ThomasBurleson ThomasBurleson added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: review This PR is waiting on review from the team labels May 8, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasBurleson ThomasBurleson added needs: presubmit and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: review This PR is waiting on review from the team cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Jun 13, 2017
@kara kara added the g3: pr This PR was posted by an internal or external product team. label Jul 18, 2017
@kara kara merged commit 71cd3e9 into angular:master Jul 18, 2017
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
g3: pr This PR was posted by an internal or external product team. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants