This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): fix long tab content not scrolling #10586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Apr 13, 2017
src/components/swipe/swipe.js
Outdated
|
|
||
| function postLink(scope, element, attr) { | ||
| var touchAction = attr['mdSwipeTouchAction'] || 'none'; | ||
| element.css('touch-action', touchAction); |
There was a problem hiding this comment.
Can't we just put that in a single line?
element.css('touch-action', attr.mdSwipeTouchAction || 'none');
jelbourn
force-pushed
the
tabs-swipe-touch-action
branch
from
5c3c15f to
0dc542b
Compare
|
Not sure if I want to advertise the API yet |
|
Hm no idea. It's a pretty simple feature. But anyways, LGTM (there is no label on M1) |
GulajavaMinistudio
added a commit
to GulajavaMinistudio/material
that referenced
this pull request
Apr 15, 2017
fix(tabs): fix long tab content not scrolling (angular#10586)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.