This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tooltip): use different attribute to track setting of aria-label #10600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started setting
aria-labelledbyon parent elements to track if thearia-labelhad already been set by the tooltip. It seems we should use a different attribute as a marker becausearia-labelledbywill take precedence overaria-labelwhen set on the same element. In this case, it will point to an element that only exists on the DOM when the tooltip is showing, which hurts accessibility. This is currently blocking 1.1.4 release due to Google breakages.cc: @ThomasBurleson