Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(slider): role was applied to inner element instead of the directive itself #10731

Merged
merged 1 commit into from
Dec 12, 2017
Merged

fix(slider): role was applied to inner element instead of the directive itself #10731

merged 1 commit into from
Dec 12, 2017

Conversation

EladBezalel
Copy link
Member

fixes #10565

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 13, 2017
@ThomasBurleson
Copy link
Contributor

@EladBezalel - lgtm

@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone Jun 13, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.5, 1.1.6 Sep 5, 2017
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed pr: needs presubmit labels Nov 21, 2017
@Splaktar Splaktar added P2: required Issues that must be fixed. a11y This issue is related to accessibility labels Dec 11, 2017
@andrewseguin andrewseguin merged commit bbb719d into master Dec 12, 2017
@Splaktar Splaktar deleted the fix/slider-role branch December 13, 2017 07:16
@Splaktar Splaktar mentioned this pull request Mar 21, 2019
Closed
@Splaktar
Copy link
Member

This fix for ChromeVox appears to have broken VoiceOver and JAWS.

Splaktar added a commit that referenced this pull request Mar 21, 2019
@Splaktar
fix(slider): aria attrs are not announced when tabbing in screen readers
578657c 
revert changes from #10731
fix inconsistencies, typos, and mistakes in the demos

Fixes #11685
Splaktar added a commit that referenced this pull request Mar 21, 2019
@Splaktar
fix(slider): aria attrs are not announced when tabbing in screen readers
e555c82 
revert changes from #10731
move a number of aria attributes from md-slider to md-slider-wrapper
fix inconsistencies, typos, and mistakes in the demos

Fixes #11685
@Splaktar Splaktar mentioned this pull request Mar 21, 2019
Merged
3 tasks
jelbourn pushed a commit that referenced this pull request Mar 28, 2019
@Splaktar @jelbourn
fix(slider): aria attrs are not announced when tabbing in screen read…
459c03c 
…ers (#11688)

revert changes from #10731
move a number of aria attributes from md-slider to md-slider-wrapper
fix inconsistencies, typos, and mistakes in the demos

Fixes #11685
@angular angular locked as resolved and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasBurleson ThomasBurleson Awaiting requested review from ThomasBurleson

Assignees
No one assigned
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.1.6
Development

Successfully merging this pull request may close these issues.

aria-label not read by ChromeVox on md-slider component
5 participants
@EladBezalel @ThomasBurleson @Splaktar @googlebot @andrewseguin