This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): unable to move text cursor and tap away on mobile #10821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes not being able to move the text cursor within and input on mobile. * Fixes not being able to blur an input by tapping away on mobile. Both of the issues were due to the click hijacking from the gesture service being too aggressive and preventing focus from shifting. Fixes angular#10301. Fixes angular#5365.
googlebot
added
the
cla: yes
|
Sent this change off to the team that raised the issue to see if it fixes what they were seeing, waiting to hear back |
|
Confirmed that this fixes the issues |
|
This also passes google presubmit |
|
@jelbourn is it ready to merge? |
|
@tinayuangao - not yet. I am still testing. |
ThomasBurleson
added
pr: lgtm
|
@tinayuangao - ready for presubmit. |
|
This problem still happening on mobile |
|
@gelordi is that with AngularJS Material 1.1.5? If so, please open a new issue with a CodePen reproduction. |
Splaktar
added
type: bug
type: gestures
ui: mobile
os: iOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the issues were due to the click hijacking from the gesture service being too aggressive and preventing focus from shifting.
Fixes #10301.
Fixes #5365.