Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(mdGesture): perf improvement with disabling of all gesture listeners #10885

Closed
wants to merge 2 commits into from

Conversation

ThomasBurleson
Copy link
Contributor

@ThomasBurleson ThomasBurleson commented Sep 5, 2017

Use this with following code sample:

app
  .module('myApp',['ngMaterial'])
  .config(['$mdGestureProvider', function($mdGestureProvider) {
    // Useful for environments where swipe and touch events are not important.
    $mdGestureProvider.disableAll();
  }])

Fixes #10884

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Sep 5, 2017
@ThomasBurleson ThomasBurleson added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Sep 5, 2017
@ThomasBurleson ThomasBurleson added this to the 1.1.6 milestone Sep 5, 2017
@angular angular deleted a comment from googlebot Sep 5, 2017
@angular angular deleted a comment from googlebot Sep 5, 2017
@Splaktar Splaktar added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Nov 15, 2017
@Splaktar Splaktar added type: performance This issue is related to performance needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Dec 18, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar added the P3: important Important issues that really should be fixed when possible. label Jan 30, 2018
@Splaktar Splaktar self-assigned this Jan 30, 2018
@Splaktar Splaktar self-requested a review January 30, 2018 03:36
@Splaktar
Copy link
Contributor

Splaktar commented Feb 7, 2018

Please rebase.

@Splaktar Splaktar modified the milestones: 1.1.7, 1.1.8 Feb 7, 2018
@Splaktar Splaktar modified the milestones: 1.1.8, 1.1.9 Mar 16, 2018
@Splaktar Splaktar added needs: review This PR is waiting on review from the team type: gestures and removed needs: review This PR is waiting on review from the team labels Apr 17, 2018
@Splaktar Splaktar removed this from the 1.1.9 milestone Apr 19, 2018
@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 19, 2018
@Splaktar
Copy link
Contributor

I am going to submit another PR with these changes, without the debugger; statement, and without the extra commit.

@Splaktar Splaktar closed this Apr 19, 2018
Splaktar added a commit that referenced this pull request Apr 19, 2018
@Splaktar Splaktar deleted the thomas/fix-issue-10884 branch April 19, 2018 20:14
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar Splaktar removed their request for review January 22, 2019 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved P3: important Important issues that really should be fixed when possible. type: gestures type: performance This issue is related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants