-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(md-menu): allow nested md-menu-content again #11103
fix(md-menu): allow nested md-menu-content again #11103
Conversation
@Splaktar Somehow the test seems to fail because of a different reason than my code. Do you know what happened here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment
if (!contentEl || contentEl.nodeName !== 'MD-MENU-CONTENT') { | ||
throw Error(INVALID_PREFIX + 'Expected the menu to contain a `md-menu-content` element.'); | ||
if (templateElement.children().length !== 2) { | ||
throw Error(INVALID_PREFIX + 'Expected two children elements.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to still kind of refer to the md-menu-content
element.
@Splaktar can this be added to milestone/release 1.1.7 or is it too late? |
@IMM0rtalis there wasn't time to get this into 1.1.7 due to how long of a process it is to get through presubmits. Please squash your commits and then I'll send this off for presubmit testing. |
bcfe1de
to
0c09b8f
Compare
@Splaktar done. |
@IMM0rtalis in order to improve the generated changelog and make sure that the related issue gets closed, please include |
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fixes misbehavior from #10198
What is the current behavior?
Issue Number: #10540
Does this PR introduce a breaking change?